Add Parquet-Exporter helm chart #195

cklingspor · 2024-04-08T06:45:11Z

Moved from opencost/opencost-parquet-exporter#10

Hey everyone,

I've created a first draft of a helm chart for the parquet-exporter. I do not have a setup where I can use AWS as of now, therefore the actual push to a S3 bucket is not yet tested. However, I was able to install the chart and run the cronjob in my minikube.

Used helm-docs to create a rough documentation around the chart
The chart itself is relatively straight forward I think
Let me know what you think!

mattray · 2024-04-08T08:09:55Z

charts/parquet-exporter/Chart.yaml

@@ -0,0 +1,24 @@
+apiVersion: v2
+name: parquet-exporter


could we make this "opencost-parquet-exporter"?

That will have a ripple effect in the templates, but I prefer the verbosity/specificity

mattray · 2024-04-08T08:10:18Z

charts/parquet-exporter/Chart.yaml

@@ -0,0 +1,24 @@
+apiVersion: v2
+name: parquet-exporter
+description: A Helm chart for Kubernetes


"OpenCost Parquet Exporter"

mattray · 2024-04-08T08:11:41Z

charts/parquet-exporter/README.md

@@ -0,0 +1,38 @@
+# parquet-exporter


Could we make the title and the path charts/opencost-parquet-exporter to match the repository?

mattray · 2024-04-08T08:11:57Z

charts/parquet-exporter/README.md

+
+| Key | Type | Default | Description |
+|-----|------|---------|-------------|
+| activeDeadlineSeconds | int | `3600` | Keep job runnig (from start time) for [activeDeadlineSeconds]   |


mattray · 2024-04-08T08:14:15Z

charts/parquet-exporter/values.yaml

+  - name: OPENCOST_PARQUET_S3_REGION
+    value: YOUR_S3_BUCKET_REGION_NAME_CHANGE_ME
+  - name: OPENCOST_PARQUET_SVC_HOSTNAME
+    value: opencost.opencost.svc.cluster.local.


is there supposed to be a trailing "."?

Yes. The dot at the end means the dns search-domain will not be appended and this is a fully qualified hostname.

mattray · 2024-04-08T08:16:35Z

charts/parquet-exporter/Chart.yaml

@@ -0,0 +1,24 @@
+apiVersion: v2
+name: parquet-exporter


That will have a ripple effect in the templates, but I prefer the verbosity/specificity

asdfgugus · 2024-04-11T21:18:09Z

charts/parquet-exporter/templates/_annotations.tpl

add new line at the end

asdfgugus · 2024-04-11T21:30:03Z

charts/parquet-exporter/values.yaml

+ttlSecondsAfterFinished: 14400
+# --  ServiceAccount use to run this pod
+serviceAccount:
+  name: opencost


Does the exporter depend on the opencost service account? I couldn't find something related to this in the exporters repo README.md.

I took that over from @lmello 's code. I have not looked into the actual requirements for the AWS S3 integration but I have to assume that its there for this purpose. Also it is not required to interact with the opencost application.
The service account key/value pair is optional however. Would you rather have me remove it from the values yaml or adjust the description to state that its an optional parameter`

If the service account is not required, I would leave it empty. Maybe also change the key to existingServiceAccount? Otherwise I would assume that it creates the service account by itself.

Thank you. Ill change accordingly!

asdfgugus · 2024-04-11T21:31:13Z

charts/parquet-exporter/templates/cronjob.yaml

add new line at the end

asdfgugus · 2024-04-11T21:31:20Z

charts/parquet-exporter/values.yaml

add new line at the end

… tag to :main, implement review comments

…sed when not empty

asdfgugus

I did not test it on my cluster, but the code LGTM.

mattray

I think the values need to move to opencost-parquet-exporter, but I didn't test.

mattray · 2024-04-16T05:25:39Z

charts/opencost-parquet-exporter/templates/_annotations.tpl

+{{/*
+Common labels
+*/}}
+{{- define "parquet-exporter.annotations" -}}


do the "parquet-exporter" references need to be changed to "opencost-parquest-exporter" across the board?

It would be consistent with actual chart name. I'll update accordingly

github-actions · 2024-06-16T01:54:36Z

This pull request has been marked as stale because it has been open for 60 days with no activity. Please remove the stale label or comment or this pull request will be closed in 5 days.

github-actions · 2024-08-18T01:57:30Z

This pull request has been marked as stale because it has been open for 60 days with no activity. Please remove the stale label or comment or this pull request will be closed in 5 days.

lmello · 2024-08-21T12:08:43Z

I will review this PR after the change to the parquet export repo is merged.
we cannot merge this PR before this is done.

lmello

Please fix the trailling whitespaces:
Error: 1:56 [trailing-spaces] trailing spaces
Error: 8:22 [trailing-spaces] trailing spaces
Error: 12:68 [trailing-spaces] trailing spaces
Error: 27:12 [trailing-spaces] trailing spaces
Error: 59:209 [trailing-spaces] trailing spaces
Error: 62:117 [trailing-spaces] trailing spaces

brito-rafa

LGTM

github-actions · 2024-10-27T02:06:02Z

This pull request has been marked as stale because it has been open for 60 days with no activity. Please remove the stale label or comment or this pull request will be closed in 5 days.

cklingspor added 2 commits April 8, 2024 08:40

Initial commit. Moved from opencost/opencost-parquet-exporter#10

da5333d

Remove .DS_Store from tracking, add .gitignore

fd08d91

cklingspor mentioned this pull request Apr 8, 2024

Add helm chart opencost/opencost-parquet-exporter#10

Closed

mattray reviewed Apr 8, 2024

View reviewed changes

mattray requested changes Apr 8, 2024

View reviewed changes

asdfgugus reviewed Apr 11, 2024

View reviewed changes

cklingspor added 3 commits April 12, 2024 10:13

Mark 'serviceAccount' key/value pair as optional in description, move…

683ee01

… tag to :main, implement review comments

Merge branch 'main' into add_parquet_exporter

7077a2d

Rename serviceAccount to existingServiceAccount, make sure its only u…

633facf

…sed when not empty

asdfgugus approved these changes Apr 12, 2024

View reviewed changes

mattray reviewed Apr 16, 2024

View reviewed changes

Reflect chart renaming in _helpers.tpl & _annotations.tpl

542bdc0

github-actions bot added the Stale label Jun 16, 2024

Merge branch 'main' into add_parquet_exporter

04783c0

mattray removed the Stale label Jun 18, 2024

github-actions bot added the Stale label Aug 18, 2024

lmello added enhancement New feature or request and removed Stale labels Aug 21, 2024

lmello requested changes Aug 21, 2024

View reviewed changes

cklingspor and others added 2 commits August 27, 2024 08:01

Merge branch 'main' into add_parquet_exporter

914de43

Remove trailing spaces

9000ec0

brito-rafa approved these changes Aug 27, 2024

View reviewed changes

github-actions bot added the Stale label Oct 27, 2024

Merge branch 'main' into add_parquet_exporter

d896e4f

github-actions bot removed the Stale label Nov 1, 2024

cklingspor added 2 commits November 1, 2024 11:54

Merge branch 'main' into add_parquet_exporter

2b45e36

Merge branch 'main' into add_parquet_exporter

ffe02b4

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Parquet-Exporter helm chart #195

Add Parquet-Exporter helm chart #195

cklingspor commented Apr 8, 2024

mattray Apr 8, 2024

mattray Apr 8, 2024

mattray Apr 8, 2024

mattray Apr 8, 2024

mattray Apr 8, 2024

mattray Apr 8, 2024

lmello Aug 21, 2024

mattray Apr 8, 2024

asdfgugus Apr 11, 2024

asdfgugus Apr 11, 2024

cklingspor Apr 12, 2024 •

edited

Loading

asdfgugus Apr 12, 2024

cklingspor Apr 12, 2024

asdfgugus Apr 11, 2024

asdfgugus Apr 11, 2024

asdfgugus left a comment

mattray left a comment

mattray Apr 16, 2024

cklingspor Apr 16, 2024

cklingspor Apr 16, 2024

github-actions bot commented Jun 16, 2024

github-actions bot commented Aug 18, 2024

lmello commented Aug 21, 2024

lmello left a comment

brito-rafa left a comment

github-actions bot commented Oct 27, 2024

Add Parquet-Exporter helm chart #195

Are you sure you want to change the base?

Add Parquet-Exporter helm chart #195

Conversation

cklingspor commented Apr 8, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cklingspor Apr 12, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

asdfgugus left a comment

Choose a reason for hiding this comment

mattray left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Jun 16, 2024

github-actions bot commented Aug 18, 2024

lmello commented Aug 21, 2024

lmello left a comment

Choose a reason for hiding this comment

brito-rafa left a comment

Choose a reason for hiding this comment

github-actions bot commented Oct 27, 2024

cklingspor Apr 12, 2024 •

edited

Loading